Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix TestOverrideReconcilerResources on Autopilot #485

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

karlkfi
Copy link
Contributor

@karlkfi karlkfi commented Mar 23, 2023

No description provided.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from karlkfi. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karlkfi
Copy link
Contributor Author

karlkfi commented Mar 23, 2023

/hold for manual testing on autopilot.

@karlkfi karlkfi changed the title Fix TestOverrideReconcilerResources on Autopilot [WIP] Fix TestOverrideReconcilerResources on Autopilot Mar 23, 2023
@karlkfi
Copy link
Contributor Author

karlkfi commented Mar 23, 2023

While this might fix the bug for these tests, I think the SkipAutopilotCluster feature itserlf might be broken, causing this test to be run when it should be skipped.

@karlkfi
Copy link
Contributor Author

karlkfi commented Mar 23, 2023

This alone does not fix the issue. The namespaces never become available in test setup:

    wait.go:122: failed after 6m0s to wait for namespace "frontend" to be ready
    wait.go:123: ERROR: namespace "frontend" GET failed: namespaces "frontend" not found
    wait.go:122: failed after 6m0s to wait for namespace "backend" to be ready
    wait.go:123: ERROR: namespace "backend" GET failed: namespaces "backend" not found

This could be due to fighting with the autopilot webhook.

@mikebz
Copy link
Contributor

mikebz commented Apr 17, 2024

curious if this is still WIP or if it's even relevant. If it is consider closing the PR and keeping the private branch or converting to draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants